From 29d722536068f5feb3e203f041df69cfa9470417 Mon Sep 17 00:00:00 2001
From: "michael.breu" <michael.breu@uibk.ac.at>
Date: Fri, 9 Apr 2021 16:12:18 +0200
Subject: [PATCH] More test coverage
---
.../uibk/gitsearch/service/SearchServiceIT.java | 1 +
.../gitsearch/service/dto/VariousDTOTest.java | 16 ++++++++++++++++
2 files changed, 17 insertions(+)
diff --git a/src/test/java/at/ac/uibk/gitsearch/service/SearchServiceIT.java b/src/test/java/at/ac/uibk/gitsearch/service/SearchServiceIT.java
index e5b1e24a1..9f80e67fe 100644
--- a/src/test/java/at/ac/uibk/gitsearch/service/SearchServiceIT.java
+++ b/src/test/java/at/ac/uibk/gitsearch/service/SearchServiceIT.java
@@ -77,6 +77,7 @@ public class SearchServiceIT {
SearchResultsDTO searchResultPage = searchService.searchResultPage(searchQuery, 0, SearchInputDTO.PAGE_SIZE);
Assert.assertTrue("At least one hit?", searchResultPage.getSearchResult().size() >= 1);
+ Assert.assertEquals("We start at 0", 0, searchResultPage.getPageStartIndex());
LOGGER.info("found {} hits for all", searchResultPage.getHitCount());
}
diff --git a/src/test/java/at/ac/uibk/gitsearch/service/dto/VariousDTOTest.java b/src/test/java/at/ac/uibk/gitsearch/service/dto/VariousDTOTest.java
index 8760fab7f..82fc78581 100644
--- a/src/test/java/at/ac/uibk/gitsearch/service/dto/VariousDTOTest.java
+++ b/src/test/java/at/ac/uibk/gitsearch/service/dto/VariousDTOTest.java
@@ -7,6 +7,8 @@ import org.junit.jupiter.api.Test;
import at.ac.uibk.gitsearch.service.MailService;
import at.ac.uibk.gitsearch.service.dto.SearchResultDTO.GitProject;
+import at.ac.uibk.gitsearch.service.dto.SearchResultsDTO.ExerciseType;
+import at.ac.uibk.gitsearch.service.dto.SearchResultsDTO.GitProjectVisibility;
import at.ac.uibk.gitsearch.service.dto.UserProvidedMetadataDTO.Person;
import at.ac.uibk.gitsearch.testingUtilities.PropertiesTester;
import nl.jqno.equalsverifier.EqualsVerifier;
@@ -37,8 +39,22 @@ public class VariousDTOTest {
propertiesTester.testProperties(SearchResultDTO.class);
propertiesTester.testProperties(Person.class);
propertiesTester.testProperties(GitProject.class);
+
+ // just for test coverage
+ SearchResultsDTO srDTO = new SearchResultsDTO(null, 0, 0);
}
+ @Test
+ public void testSearchResultsEnums() throws IllegalAccessException, InvocationTargetException {
+ for(ExerciseType et: ExerciseType.values()) {
+ et.getExternalName();
+ }
+
+ for(GitProjectVisibility vis: GitProjectVisibility.values()) {
+ vis.getExternalName();
+ }
+ }
+
@org.junit.jupiter.api.Test
public void testSearchInputDTO() throws IllegalAccessException, InvocationTargetException {
propertiesTester.testProperties(SearchInputDTO.class);
--
GitLab