Intermediate commit: fixing for sonar (2)

src/main/java/at/ac/uibk/gitsearch/repository/search/SearchRepositoryConstants.java

 package at.ac.uibk.gitsearch.repository.search;
 
-public interface SearchRepositoryConstants {
+public final class SearchRepositoryConstants {
 
     public static final String INDEX_FULLTEXT = "fulltext";
     public static final String INDEX_METADATA = "metadata";
@@ -28,4 +28,7 @@ public interface SearchRepositoryConstants {
     public static final String PROJECT_VISIBILITY = "project.visibility";
     public static final String PROJECT_NAMESPACE = "project.namespace";
     
+    private SearchRepositoryConstants() {
+    	// just a list of constants
+    }
 }

src/main/java/at/ac/uibk/gitsearch/service/SearchService.java

@@ -7,10 +7,7 @@ import java.net.URISyntaxException;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
-import java.util.Optional;
 
-import org.gitlab4j.api.Constants.TokenType;
-import org.gitlab4j.api.GitLabApi;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -113,7 +110,7 @@ public class SearchService {
 		pageDetails.getSearchResult().stream().forEach(
 				hit -> pluginManagementService.getRegisteredPluginConfigs().stream()
 				.forEach(config -> config.getActions().values().stream().filter(action -> action.isApplicable(hit)).forEach(action -> hit.getSupportedActions().add(action.getPluginActionInfo()))) );
-		pageDetails.getSearchResult().stream().forEach(md -> fixImageURL(md));
+		pageDetails.getSearchResult().stream().forEach(this::fixImageURL);
 
 		return pageDetails;
 //		return readTestResults(searchInput.getFulltextQuery(), first, length);

src/main/java/at/ac/uibk/gitsearch/service/oauth2/OAuth2ConfigService.java

@@ -36,7 +36,7 @@ public class OAuth2ConfigService {
 	public List<OAuth2ConfigDTO> getPublicRegistrations() {
     	if (oauth2ClientRegistrationRepositories instanceof InMemoryClientRegistrationRepository) {
 			InMemoryClientRegistrationRepository imOAuth2ClientRegistrationRepositories = (InMemoryClientRegistrationRepository) oauth2ClientRegistrationRepositories;
-			final List<OAuth2ConfigDTO> result = new ArrayList<OAuth2ConfigDTO>();
+			final List<OAuth2ConfigDTO> result = new ArrayList<>();
 			imOAuth2ClientRegistrationRepositories.iterator().forEachRemaining(registration -> result.add(buildConfigFromRegistration(registration)));
 			return result;
     	}

src/main/webapp/app/exercise/exercise-card/exercise-card.component.html

@@ -19,18 +19,6 @@
                                               'star-unmarked': exercise.rating < starNumber}">
                             </span>
                     </div>
-                    <!--<div class="rate">
-                        <input type="radio" id="card-star5" name="rate" value="5" />
-                        <label for="card-star5" title="text">5 stars</label>
-                        <input type="radio" id="card-star4" name="rate" value="4" />
-                        <label for="card-star4" title="text">4 stars</label>
-                        <input type="radio" id="card-star3" name="rate" value="3" />
-                        <label for="card-star3" title="text">3 stars</label>
-                        <input type="radio" id="card-star2" name="rate" value="2" />
-                        <label for="card-star2" title="text">2 stars</label>
-                        <input type="radio" id="card-star1" name="rate" value="1" />
-                        <label for="card-star1" title="text">1 star</label>
-                    </div>-->
                 </div> <!-- card rating end-->
 
                 <!-- card bookmark-->

src/main/webapp/app/exercise/exercise-details/exercise-details.component.html

@@ -35,18 +35,6 @@
                                                               'star-unmarked': exercise.rating < starNumber}">
                                         </span>
                                     </div>
-                                    <!--<div class="rate">
-                                        <input type="radio" id="modal-star5" name="rate" value="5" />
-                                        <label for="modal-star5" title="text">5 stars</label>
-                                        <input type="radio" id="modal-star4" name="rate" value="4" />
-                                        <label for="modal-star4" title="text">4 stars</label>
-                                        <input type="radio" id="modal-star3" name="rate" value="3" />
-                                        <label for="modal-star3" title="text">3 stars</label>
-                                        <input type="radio" id="modal-star2" name="rate" value="2" />
-                                        <label for="modal-star2" title="text">2 stars</label>
-                                        <input type="radio" id="modal-star1" name="rate" value="1" />
-                                        <label for="modal-star1" title="text">1 star</label>
-                                    </div>-->
                                 </div> <!-- modal rating end-->
 
                                 <div *ngIf="exercise.rating"

src/main/webapp/app/home/home.component.html

 <div><!--  just a wrapper  -->
 <div class="row">
     <div class="col-md-12">
-    	<h1 style="padding: 50px 0px 15px 0px;" align="center" jhiTranslate="home.title">Browse our popular content</h1>
+    	<h1 style="padding: 50px 0px 15px 0px;text-align:center" jhiTranslate="home.title">Browse our popular content</h1>
 		<!-- <h4 style="margin-bottom: 50px" align="center" jhiTranslate="home.subtitle">An optional subheadline for additional information</h4>  -->
 		<div jhiTranslate="home.teaser" style="width: 80%; margin-left: auto; margin-right: auto;">teaser text </div>
         <div [ngSwitch]="isAuthenticated()">

src/main/webapp/app/layouts/footer/footer.component.html

 <div class="footer">
-<!--
-    <p jhiTranslate="footer">More information can be found <a href="https://sharing-codeability.uibk.ac.at/static/SharingCodeAbility.html">here</a>!</p>
-     -->
     <div class="container-fluid">
       <div class="row">
         <div class="col-4">
@@ -15,18 +12,6 @@
               <li><a href="https://codeability.uibk.ac.at/" jhiTranslate="global.footer.about">About codeAbility</a></li>
             </ul>
           </div>
-          <!--
-          <div style="float: left; padding-top: 15px;">
-            <ul>
-              <li><a href="#">About this platform</a></li>
-            </ul>
-          </div>
-          <div style="float: left; padding-top: 15px;">
-            <ul>
-              <li><a href="https://artemis.codeability.uibk.ac.at/#/datenschutz">Data Protection</a></li>
-            </ul>
-          </div>
-          -->
           <div style="float: left; padding-top: 15px;">
             <ul>
               <li><a href="https://www.uibk.ac.at/informatik/"  jhiTranslate="global.footer.imprint">Imprint</a></li>

src/main/webapp/app/layouts/navbar/navbar.component.html

@@ -36,7 +36,6 @@
                         <li *ngFor="let language of languages">
                             <a class="dropdown-item" [jhiActiveMenu]="language" href="javascript:void(0);"
                                (click)="changeLanguage(language);collapseNavbar();">{{ language | findLanguageFromKey }}</a>
-                            <!-- not used <span class="spawn-submenu">{{ language }}</span> -->
                         </li>
                     </ul>
                 </div>