Fix secrets in source code!

mentioned in merge request !6 (closed)

created merge request !6 (closed) to address this issue

created merge request !7 (merged) to address this issue

mentioned in merge request !7 (merged)

assigned to @lukas.kaltenbrunner

Hallo Lukas,

Ich habe jetzt (für Staging) die Secrets in eine .env Datei ausgelagert. Die .env Datei ist (als Note) im KeyPass gespeichert. Für die Produktion sollten wir das analog machen.

Ich hab's (vorerst sehr grob) unter https://sharing-codeability.uibk.ac.at/sharing/codeability-sharing-platform/-/wikis/technical/setup/Update-Setup-Sharing-Plattform dokumentiert.

Für die Entwicklung lassen wir die Secrets vorerst plain im Repository. Ich denke, dass können wir vorerst verantworten.

Kannst Du mal drübergehen und ggf. Feedback liefern, bzw. das Ticket schliessen?

Danke Michael

In general, this should work as expected to set up GitSearch. However, I have some remarks:

• GIT_COMMITID should be COMMIT_ID?
• There is no staging profile in the pom.xml. -Pstaging is not needed? ([WARNING] The requested profile "staging" could not be activated because it does not exist.)
• To set up the GitSearch from scratch I had to use docker-compose -f gitsearch.yml up -d --no-deps --build rather than docker-compose -f gitsearch.yml up -d --no-deps --build gitsearch-app
• I tested this setup for the master and development branch. It did not work for the commit id cb5ae1c6 (development). When selecting the appropriate image in gitsearch.yml it works just fine for the master branch.

Compilation failure
[ERROR] /Users/lukaskaltenbrunner/Documents/Uni/CodeAbility/Sharing/codeability-sharing-platform/src/main/java/at/ac/uibk/gitsearch/service/ShoppingBasketService.java:[239,55] no suitable constructor found for ShoppingBasket(org.codeability.sharing.plugins.api.ShoppingBasket.UserInfo,org.codeability.sharing.plugins.api.ShoppingBasket.ExerciseInfo[])
[ERROR]     constructor org.codeability.sharing.plugins.api.ShoppingBasket.ShoppingBasket(org.codeability.sharing.plugins.api.ShoppingBasket.UserInfo,org.codeability.sharing.plugins.api.ShoppingBasket.ExerciseInfo[],long) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR]     constructor org.codeability.sharing.plugins.api.ShoppingBasket.ShoppingBasket() is not applicable
[ERROR]       (actual and formal argument lists differ in length)

I executed the following script in the root directory:

if [ "$#" -ne 1 ]; then
  echo "usage: $0 <MYSQL_HOME>" 1>&2
  exit 1
fi
export MYSQL_HOME="$1"
sudo ./mvnw -Dmaven.test.failure.ignore=true package -Pstaging jib:dockerBuild 
export GIT_BRANCH=$(git rev-parse --abbrev-ref HEAD)
export COMMIT_ID=$(git rev-parse HEAD)
sudo -E docker-compose -f src/main/docker/gitsearch.yml up -d --no-deps --build

Note that just the setup of GitSearch was tested.

assigned to @Michael.Breu and unassigned @lukas.kaltenbrunner

changed milestone to %2021 March Sprint Sharing Plattform

• GIT_COMMITID should be COMMIT_ID?

Wurde korrigiert. Verstehe aber nicht, warum dennoch funktioniert hat.

• There is no staging profile in the pom.xml. -Pstaging is not needed? ([WARNING] The requested profile "staging" could not be activated because it does not exist.)

Diese Fehlermeldung taucht bei mir unter sudo ./mvnw -Dmaven.test.failure.ignore=true package -Pstaging jib:dockerBuild nicht auf. Scheint momentan kein Problem zu sein.

• To set up the GitSearch from scratch I had to use docker-compose -f gitsearch.yml up -d --no-deps --build rather than docker-compose -f gitsearch.yml up -d --no-deps --build gitsearch-app

Bei mir funktioniert beides.

• I tested this setup for the master and development branch. It did not work for the commit id cb5ae1c6 (development). When selecting the appropriate image in gitsearch.yml it works just fine for the master branch.

Da habe ich leider für die PluginApi die Versionierung versaut (eine alte Version mit einer inkomptiblen Version überschrieben). Sorry. Sollte jetzt funktionieren.

closed