This is the codeAbility Sharing Platform! Learn more about the codeAbility Sharing Platform.

Skip to content
Snippets Groups Projects

Resolve "Reviewing Badges: Zusätzliche Icons"

Merged Michael Breu requested to merge 397-reviewing-badges-zusatzliche-icons into development
Viewing commit 83ab4c55
Show latest version
1 file
+ 14
8
Compare changes
  • Side-by-side
  • Inline
@@ -21,13 +21,17 @@ import { ReviewManagementService } from 'app/admin/review-management/review-mana
const stats = {
reviewInProgress: 1,
reviewImproved: 2,
reviewImprovementRequested: 2,
reviewCompleted: 3,
reviewRequested: 13,
unknownStats: 4,
reviewsRequestedByReviewer: 5,
reviewsAssignedToReviewer: 5,
reviewInProgressByReviewer: 6,
reviewImprovementRequestedByReviewer: 7,
reviewImprovedForReviewer: 7,
reviewCompletedByReviewer: 8,
unkownStatsByReviewer: 9,
reviewRejectedByReviewer: 11,
reviewImprovementRequestedByReviewer: 12,
badgesRewarded: 10,
};
@@ -71,8 +75,10 @@ describe('ReviewMenuBadgeComponent Component', () => {
});
testRequest.flush(stats);
expect(comp.getCount()).toEqual(stats.reviewInProgress + stats.reviewImproved);
expect(comp.getLabel()).toEqual('1 item(s) for review.\n2 improved item(s) for review');
expect(comp.getCount()).toEqual(stats.reviewInProgressByReviewer + stats.reviewImprovedForReviewer);
expect(comp.getLabel()).toEqual(
`${stats.reviewInProgressByReviewer} item(s) for review.\n${stats.reviewImprovedForReviewer} improved item(s) for review`
);
});
});
@@ -116,8 +122,8 @@ describe('ReviewRequestedMenuBadge Component', () => {
});
testRequest.flush(stats);
expect(comp.getCount()).toEqual(stats.reviewsRequestedByReviewer);
expect(comp.getLabel()).toEqual('5 reviews request, but not yet assigned.');
expect(comp.getCount()).toEqual(stats.reviewsAssignedToReviewer);
expect(comp.getLabel()).toEqual('5 open review request(s).');
});
});
@@ -161,8 +167,8 @@ describe('ImprovementsRequestedMenuBadge Component', () => {
});
testRequest.flush(stats);
expect(comp.getCount()).toEqual(7);
expect(comp.getLabel()).toEqual('7 review(s) resulted in an improvements request');
expect(comp.getCount()).toEqual(stats.reviewImprovementRequested);
expect(comp.getLabel()).toEqual(`${stats.reviewImprovementRequested} review(s) resulted in an improvements request`);
});
});