Linter für GitSearch

changed milestone to %2021 Aug Sprint

assigned to @danielrainer and unassigned @Michael.Breu

changed milestone to %2021 September Sprint

Hallo Daniel,

Ich bin mir nicht sicher, ob der Request nicht eh von Dir kam.

Falls nicht, kannst Du das Ticket einfach schließen.

Michael

mentioned in issue #120 (closed)

changed milestone to %2021 Oktober Sprint

#220 (closed) tracks the equivalent issue for the filehooks project. I use that project to experiment with potential approaches, since I am more familiar with that codebase. Some of the tools used there might also be useful for this gitsearch.

In the filehooks project pre-commit is used, which is a python tool handling git hooks. husky is an alternative which is used for Artemis.

We need to decide on one or more linters for Java and Typescript (an potentially HTML and CSS), and some code style we want to follow.

The filehooks pre-commit hooks also runs the unit tests, since they run fairly quickly, but the gitsearch tests are probably too slow to run on every commit, but they already run in GitLab, so failures will are there.

changed milestone to %2021 November Sprint

assigned to @eduard.frankford and unassigned @danielrainer

assigned to @danielrainer and unassigned @eduard.frankford

While @danielrainer is experimenting with the filehooks project I will take a look at the git search project. :-)

changed milestone to %2021 Dezember Sprint

changed milestone to %2022 Januar Sprint

Waiting for resolution of the dependency management issues in #195 (closed).

unassigned @danielrainer

assigned to @danielrainer

Das aktivieren von Linter auf Entwicklerseite als pre-commit-hook ist nur die halbe Miete.

Wichtiger wäre, die CI-Pipeline um eine Prüfung mit Linter zu ergänzen (ist eh schon der Fall), und sicherstellen, dass vor dem Merge die Tests und Linterergebnisse einsehehbar sind.

changed milestone to %2022 März Sprint

!95 (merged) addresses a few points. There still is no pretty UI integration, but at least there are a few more checks which give a warning about issues.

As !95 (merged) is merged now I will close this. If we have specific linter requests, we can address them in separate issues.

closed